Add onunmount hook (#1212) #1234
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1234 +/- ##
=========================================
Coverage ? 91.65%
=========================================
Files ? 127
Lines ? 4579
Branches ? 1500
=========================================
Hits ? 4197
Misses ? 159
Partials ? 223
Continue to review full report at Codecov.
|
|
I finally got around to trying to solve the problem this PR was for (including CodeMirror - EasyMDE to be precise) with actions, which works much better. Can we close this PR and assume that #1212 is generally fixed with actions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure this is PR-material, as I have to admit that I have no clear idea of what I'm doing.
Edit: Attempt at Issue #1212. Will improve coverage when this is the right direction.
In my case the problem (on the surface) was that in ondestroy a referenced DOM-node didn't have a parentNode. So that's what I tested against.
Interestingly, in ondestroy on a root component, the parentNode is still there. That's why the lifecycle-events-test got a nested component.
(Maybe ondestroy could simply fire before detachment?)
It seemed easiest to just add an onunmount-hook. This magically disappears in the compiled output if unused, and doesn't hurt any tests.